Skip to content

Comments

Codex-generated pull request#2

Merged
GsCommand merged 2 commits intomainfrom
codex/review-and-rewrite-readme-for-documentation-5tftkj
Feb 15, 2026
Merged

Codex-generated pull request#2
GsCommand merged 2 commits intomainfrom
codex/review-and-rewrite-readme-for-documentation-5tftkj

Conversation

@GsCommand
Copy link
Contributor

Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.


Codex Task

@GsCommand GsCommand merged commit 3cfb364 into main Feb 15, 2026
1 check passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70e6aca113

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +20 to +23
function originAllowed(origin) {
if (!origin) return true; // non-browser / same-origin requests
if (CORS_ALLOW_ORIGINS.includes("*")) return true;
return CORS_ALLOW_ORIGINS.includes(origin);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Permit same-origin Origin headers by default

originAllowed only accepts requests with no Origin header or an explicit allowlist match, so with the default empty CORS_ALLOW_ORIGINS any request that includes Origin is rejected at middleware with 403. This breaks legitimate same-origin browser calls that still send Origin (commonly non-GET fetch/XHR), so a default deployment can fail browser traffic even when frontend and API share the same host.

Useful? React with 👍 / 👎.

@GsCommand GsCommand deleted the codex/review-and-rewrite-readme-for-documentation-5tftkj branch February 15, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant