Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cl.sig.pub+cl.sig.kidon a signer ENS name referenced by the agent'scl.receipt.signerTXT entry.Description
resolveSignerKey(name, rpcUrl): Promise<{ algorithm, kid, rawPublicKeyBytes }>which: resolves the agent ENS name'scl.receipt.signerTXT, then resolves the signer ENS name'scl.sig.pubandcl.sig.kid, parses thecl.sig.pubinto raw Ed25519 bytes, and throws clear errors when resolver/TXT keys are missing or malformed.verifyReceipt(...)to prefer an explicitpublicKeywhen provided and otherwise callresolveSignerKey(opts.ens.name, opts.ens.rpcUrl)for ENS-based verification; theens_txt_keycontext now indicates the two-hop pathcl.receipt.signer -> cl.sig.pub, cl.sig.kid.cl.pubkey/cl.receipt.pubkey_pemlookups in ENS verification and replaced it with thecl.sig.pub+cl.sig.kidflow.SignerKeyResolutiontype and improved error handling messages so ENS lookup failures and malformed key material produce explicit throw messages.README.md) to describe the new required TXT records (cl.receipt.signer,cl.sig.pub,cl.sig.kid) and adjusted the example ENS name.scripts/unit-tests.mjs) to mock ENS resolution and cover successfulresolveSignerKeyresolution, clear error paths for missing/malformed TXT values, and end-to-endverifyReceiptusing ENS-based signer key resolution.Testing
npm run buildintypescript-sdkand the build completed successfully.npm run test:unitand all unit tests passed (38 passed, 0 failed).npm test(unit + CLI smoke) and all tests passed.Codex Task