BaseAttribute HelpText localization can not use internal properties.

[ILMTitan]

PR #356 fixes issue #330 by allowing HelpText to be read from a static property. However, the current implentation restricts the use of internal classes and properties.

Resx files are a common way to store localized text, and MSBuild will automatically generate a class with static properites representing the localized value, by using the resgen utility. By default, resgen will generate an internal class with internal properties.

I propose the visibility restrictions be relaxed, as the reflection code being called works regardless of visibility.

[ILMTitan]

@moh-hassan said:

Localization in .NET is based on public (not internal) resources. For example, in DataAnnotation DisplayAttribute, it check for visibility and fire exception for internal resources .

because:

Resources may move to satellite assemblies, and internal resources are not visible to other assemblies.
In WPF application, Xaml can't use internal resources.
For these reasons, localization in PR #356 check for visibility and fire exception for internal resources .

I know, in VS IDE by default, resources are internal, but this can be modified easily.

Is there any problems in using public resources?

I suppose there are not any actual problems. I thought it was an odd restriction, but I suppose there are reasons for it.