Add support for TimeSpan#205
Conversation
|
It looks fine now. You can merge if you think this is a good addition. |
|
Oh and by the way, I found why 30 tests were failing: because |
The purpose of this commit is to trigger CI on AppVeyor to verify that all tests are passing since 30 of them do not pass on my machine (macOS 10.12.6 with JetBrains Rider 2017.3 and mono 5.4.1.7)
|
This is great - not only will it work for TimeSpans, but any class with a TypeConverter should be supported by the library now. Thank you for contributing, @0xced! |
|
@0xced hey cedric, regarding the tests and the maximumLength, you are exactly right. I was trying to find some time to implement that aspect in the testing apparatus to force that variable to always be 80 instead of -1 if the Console.WindowWidth access failed. You'll probably see a pull request from me regarding that at some point |
|
I noticed that this pull request was merged (into develop) but only commit 6e52805 was cherry-picked for version 2.2.1. Are you going to merge it in into master for the next release? |
3 participants
This is a work in progress, please do not merge yet.