Skip to content

Conversation

@emmenko
Copy link
Member

@emmenko emmenko commented Aug 18, 2020

This should hopefully fix the issue we're currently having on CI when installing tar packages:

cb.apply is not a function

See related issue: nodejs/help#2874

@emmenko emmenko force-pushed the nm-fix-node-versions branch from 2d49053 to 5567437 Compare August 18, 2020 10:50
@emmenko emmenko force-pushed the nm-fix-node-versions branch from 5567437 to 4c5a8ea Compare August 18, 2020 10:57
@emmenko emmenko force-pushed the nm-fix-node-versions branch from a6f3735 to 2b10acb Compare August 18, 2020 11:20
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1604 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1604   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         128      128           
  Lines        3325     3325           
  Branches      765      765           
=======================================
  Hits         3280     3280           
  Misses         41       41           
  Partials        4        4           
Impacted Files Coverage Δ
packages/sdk-auth/src/tokenProvider.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1cc8e1...219db5a. Read the comment docs.

@emmenko
Copy link
Member Author

emmenko commented Aug 18, 2020

Alright, this seems to fix the issue. Merging to unblock master and the other PRs.

@emmenko emmenko merged commit 397f5b4 into master Aug 18, 2020
@emmenko emmenko deleted the nm-fix-node-versions branch August 18, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant