FEC-241 : Migrate DiscountOnTotalPrice & DiscountedTotalPricePortion to use new model#815
Merged
rajrdk merged 8 commits intoMay 14, 2025
Conversation
🦋 Changeset detectedLatest commit: 539bc24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
CarlosCortizasCT
left a comment
CarlosCortizasCT
left a comment
There was a problem hiding this comment.
Just a couple of suggestions. Otherwise looks very good 👍
Rombelirk
approved these changes
May 14, 2025
Contributor
CarlosCortizasCT
left a comment
CarlosCortizasCT
left a comment
There was a problem hiding this comment.
I added this small commit (f3feaca) to make sure we export the types for the DiscountOnTotalPrice model and we do it the same way for that and the other new one.
emmenko
approved these changes
May 14, 2025
leventekobor
approved these changes
May 14, 2025
rajrdk
deleted the
fec-241-migrate-discount-on-total-price-and-discounted-total-price-portion
branch
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary : Migrating DiscountOnTotalPrice & DiscountedTotalPricePortion to new model
https://commercetools.atlassian.net/browse/FEC-241
Documentation
https://docs.commercetools.com/api/projects/carts#discountontotalprice
https://docs.commercetools.com/api/projects/carts#discountedtotalpriceportion