Skip to content

chore(travis): add config#13

Merged
adnasa merged 2 commits into
masterfrom
adnasa-travis-ci
Sep 4, 2018
Merged

chore(travis): add config#13
adnasa merged 2 commits into
masterfrom
adnasa-travis-ci

Conversation

@adnasa
Copy link
Copy Markdown
Contributor

@adnasa adnasa commented Sep 4, 2018 •
edited
Loading

Aight, this is my very first attempt to travis ci... ever! 😓

open question(s)

I simply chose nodejs 8, since there was no engine requirement in package.json. Shall we set this to nodejs10 (ref)

closes #1

@adnasa adnasa self-assigned this Sep 4, 2018
dferber90
dferber90 reviewed Sep 4, 2018
View reviewed changes
Comment thread .travis.yml Outdated

script:
- npm run lint
- npm run test
Copy link
Copy Markdown
Contributor

@dferber90 dferber90 Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use yarn to run these scripts?

Copy link
Copy Markdown
Contributor Author

@adnasa adnasa Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

you got it

@montezume
Copy link
Copy Markdown
Contributor

montezume commented Sep 4, 2018

I would be interested in moving to node 10... what do you think @emmenko @dferber90 ?

@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Sep 4, 2018

Shall we update the engine requirement first?

@montezume
Copy link
Copy Markdown
Contributor

montezume commented Sep 4, 2018

@adnasa or just add one, I don't see any listed.

emmenko
emmenko requested changes Sep 4, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

Comment thread .travis.yml
sudo: false
language: node_js
node_js:
- '8'
Copy link
Copy Markdown
Member

@emmenko emmenko Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 10

Copy link
Copy Markdown
Contributor

@dferber90 dferber90 Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this @adnasa ?

Comment thread .travis.yml
@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Sep 4, 2018

looks like netlify deployment failed when I set it to 10.8.0, will try with 10.5.0

@emmenko
Copy link
Copy Markdown
Member

emmenko commented Sep 4, 2018 

2:44:15 PM: Installing NPM modules using Yarn version 1.3.2
2:44:16 PM: yarn install v1.3.2
2:44:16 PM: [1/5] Validating package.json...
2:44:16 PM: error @commercetools-frontend/ui-kit@1.0.0-beta.30: The engine "node" is incompatible with this module. Expected version ">=10.8.0".
2:44:16 PM: error Found incompatible module
2:44:17 PM: info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
2:44:17 PM: Error during Yarn install
2:44:17 PM: Error running command: Build script returned non-zero exit code: 1

@emmenko
Copy link
Copy Markdown
Member

emmenko commented Sep 4, 2018

Keep the engine out for now

@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Sep 4, 2018

okay, thanks.
will update the lint command as you asked :)

@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Sep 4, 2018

config added, and lint command updated.. anything to add?

montezume
montezume approved these changes Sep 4, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@montezume montezume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👦 💵

@adnasa adnasa merged commit 201fa74 into master Sep 4, 2018
@adnasa adnasa deleted the adnasa-travis-ci branch September 4, 2018 13:16
@emmenko
Copy link
Copy Markdown
Member

emmenko commented Sep 4, 2018

We're using jest runners, so you can just do yarn run jest --projects jest.*.config.js.

Can you change to this for CI?

Also it still runs on node 8. Can you change it to 10?

@adnasa adnasa mentioned this pull request Sep 4, 2018
Merged
@misama-ct misama-ct mentioned this pull request Apr 1, 2026
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmenko emmenko emmenko requested changes

+2 more reviewers

@dferber90 dferber90 dferber90 approved these changes

@montezume montezume montezume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adnasa adnasa

Labels

🔮 Type: Chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setup CI

4 participants

@adnasa @montezume @emmenko @dferber90