Craft 2104 | ensure localized date time format strings display the correct format for the locale#3218
Merged
Merged
Conversation
…tToParts to generate localized date and time format description strings instead of relying on moment.js locale descriptions functions, since moment.js does not include format informations for many english locales and falls back to en which uses US mm/dd/yyyy formatting, which is incorrect as the vast majority of en locales use dd/mm/yyyy formatting. Add test for en-be formatting description to ensure that locales moment uses a fallback for are now displaying the correct format string
…re that us-formatted en locales return correctly
ByronDWall
requested review from
ddouglasz,
jaikamat,
misama-ct,
stephsprinkle,
tylermorrisford and
valoriecarli
🦋 Changeset detectedLatest commit: fe32223 The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tylermorrisford
approved these changes
Feb 10, 2026
valoriecarli
approved these changes
Feb 10, 2026
Contributor
Author
|
[preview_deployment] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
getLocalizedDateTimeFormatPatternutility to generate localized date and time format strings using the nativeIntl.DateTimeFormat.formatToPartsAPI instead of relying onmoment.js. This change improves accuracy for locales not covered bymoment.js, reduces external dependencies, and modernizes the codebase. It also updates related tests and documentation to reflect this new approach.Related to this app-kit update
Core logic changes:
moment.js-based locale format extraction ingetLocalizedDateTimeFormatPatternwith new functions (getIntlDatePatternandgetIntlTimePattern) that useIntl.DateTimeFormat.formatToPartsfor constructing localized date and time patterns. (packages/calendar-time-utils/src/calendar-time.ts) [1] [2]Intlrather thanmoment.js. (packages/calendar-time-utils/src/calendar-time.ts)Testing and coverage:
calendar-time.spec.jsto include locales not supported bymoment.js(e.g.,en-BE,en-GU) and verify correct pattern generation with the new implementation. (packages/calendar-time-utils/src/calendar-time.spec.js) [1] [2] [3]Documentation and release notes:
moment.jstoIntl.DateTimeFormat.formatToPartsfor localized format generation. (.changeset/nine-dolls-press.md)