disallow package names with "words" consisting solely of numbers#1338
Merged
mgsloan merged 1 commit intocommercialhaskell:masterfrom Nov 14, 2015
Merged
Conversation
The Cabal rule that each alphanumeric "word" between hyphens must include at least one letter is now enforced. fixes commercialhaskell#1336
mgsloan
added a commit
that referenced
this pull request
Nov 14, 2015
disallow package names with "words" consisting solely of numbers
Contributor
|
Good stuff, thanks! I can't reproduce the issue with building an |
Collaborator
Author
|
Ah, yes the problem with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1336, but now allows package names that cause a different error to happen when you try to build:
The error on attempting to build is of course not ideal.
It's caused by a "word" starting with a number, which is now allowed in my code. Cabal itself doesn't seem to care, but stack apparently does internally somewhere. It's related to the
PackageIdentifierstuff of course, but I haven't looked deeper yet.So, my question: should I just disallow that case, even though Cabal doesn't seem to care? Or should I actually attempt to fix the build error instead?
On another, only tangentially related note: are project names with underscores in them meant to be forbidden? They were by the old code and are by my change as well, but Cabal itself doesn't seem to care at all, and there's quite a few on Hackage that have underscores as well so it seems a bit odd to disallow them.Edit: nevermind the strikeout part, turns out I was hallucinating the ones on hackage