[RFC] Send output of building setup to stderr (fixes #1410)

[rvion]

this PR

• rename runIn to runCmd
• add a new runCmd' function taking and extra (CreateProcess -> CreateProcess) param
• fixes Send output of building Setup.hs to stderr #1410 by using runCmd' (\cp -> cp { std_out = UseHandle stderr }) in getSetupExe
• define a new data CMD = CMD directoryToRunIn commandToRun envOverride commandLineArguments
• refactor runIn, callProcess, callProcess' to take a CMD arg to ease code exploration, and argument passing

[rvion]

can someone review 5f9c75e ? I'm unsure about it.
I like it but I have no certitudes since it's my first dive into stack code

[rvion]

one of my motivations to refactor runIn, callProcess, callProcess' was that they were taking arguments in different order, and that it was harder to explore the code without a common CMD prefix.

[mgsloan]

5f9c75e seems good to me. I have the following nitpicks:

• It'd be better to move the CMD type into System.Process.Run
• Personally, I prefer camel-case acronyms, like Cmd. Not that this style guide is authoritative

The other commits look good too, thanks for working on this!

For some reason the build is failing in the windows CI: https://ci.appveyor.com/project/snoyberg/stack/build/1.0.546#L766

[rvion]

@mgsloan I rebased it cleanly on master, and tweaked it according to your comments

[borsboom]

Looks like you might have accidentally added test.dot and test.html to the root in 3d49b6c.

It's failing to build on Windows because there is some CPP in Stack/Exec.hs to use callProcess on Windows, since it doesn't support the exec* system calls.

[rvion]

@borsboom thanks
I think I've fixed those

[mgsloan]

Changes look good to me, One last thing before merging:

Can you please use git rebase --interactive to squash the test.dot / test.html removal commit atop 3d49b6c? Then, force push your branch. Thanks!

[rvion]

I've squashed it all on one single commit

[mgsloan]

Thanks!