Support for detailed-0.9 test type#1447
Merged
mgsloan merged 1 commit intocommercialhaskell:masterfrom Dec 3, 2015
Merged
Conversation
Contributor
|
Thanks for working on this! I've added a couple comments.
Seems fine to me, the only issue is #1302
Is this necessary? The existing code already writes to logfiles when not outputting to the console (e.g. when running tests in parallel). If a logfile is necessary, though, something which uses some suffix like "test-detailed" alongw tih
Throwing an error seems reasonable. |
00fb0c3 to
8fc49b9
Compare
8fc49b9 to
50dd563
Compare
mgsloan
added a commit
that referenced
this pull request
Dec 3, 2015
Support for detailed-0.9 test type
Contributor
|
Thanks! |
1 similar comment
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WIP] resolves #1429
TODO:
clean up test output(related to missing newline at the end of "Progress: 1/2" #1302)TestTypeTestSuiteInterfacestack test --coverage