improve unicode handling#1492
Merged
mgsloan merged 10 commits intocommercialhaskell:masterfrom Dec 11, 2015
Merged
Conversation
Previously only ASCII really works correctly, everything else breaks pretty badly. This is a step towards fixing issue commercialhaskell#1337
Collaborator
Author
|
The travis build failure appears to be because Edit: fixed |
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP attempt to fix #1337.
It's a refactor with very minor changes of my previous attempt (mostly cleaned up history and manually reviewed the changes I'd done to make sure they ... actually made sense).
Comments welcome, and I'm still testing and working on adding integration tests and such.