Skip to content

All test suites run even when only one is requested #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgsloan merged 2 commits into from
Dec 21, 2015
Merged

All test suites run even when only one is requested #1550

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dca839
Extract variable
DaveCTurner Dec 21, 2015
7b18677
Filter suitesToRun according to testsToRun
DaveCTurner Dec 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Stack/Build/Execute.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,7 +1179,14 @@ singleTest runInBase topts testsToRun ac ee task installedMap = do
hpcDir <- hpcDirFromDir pkgDir
when needHpc (createTree hpcDir)

errs <- liftM Map.unions $ forM (Map.toList (packageTests package)) $ \(testName, suiteInterface) -> do
let suitesToRun
= [ testSuitePair
| testSuitePair <- Map.toList $ packageTests package
, let testName = fst testSuitePair
, testName `elem` testsToRun
]

errs <- liftM Map.unions $ forM suitesToRun $ \(testName, suiteInterface) -> do
let stestName = T.unpack testName
(testName', isTestTypeLib) <-
case suiteInterface of
Expand Down