give better errors for broken templates#1555
Merged
mgsloan merged 2 commits intocommercialhaskell:masterfrom Dec 22, 2015
Merged
give better errors for broken templates#1555mgsloan merged 2 commits intocommercialhaskell:masterfrom
mgsloan merged 2 commits intocommercialhaskell:masterfrom
Conversation
Collaborator
Author
|
Upon review, the error messages sound rather badly worded; I'll fix them up in the morning. |
7fc1f82 to
c3674b0
Compare
Collaborator
Author
|
I think I'm happier with these errors, and it seems to work fine: Note that although the empty template error is technically redundant (it'll obviously be missing a .cabal file too in that case), I think it's probably still useful since it probably points to an empty template rather than one that someone forgot to add a .cabal file to. |
Contributor
|
LGTM, thanks! |
mgsloan
added a commit
that referenced
this pull request
Dec 22, 2015
give better errors for broken templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1535