Skip to content

Add warning if Cabal mismatch detected. #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snoyberg merged 1 commit into from
Feb 20, 2017
Merged

Add warning if Cabal mismatch detected. #2970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/Stack/Build/Installed.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,13 @@ processLoadResult _ True (WrongVersion actual wanted, lh)
]
return (Just lh)
processLoadResult mdb _ (reason, lh) = do
let pkgName = packageNameText (fst (lhPair lh))
warnIfCabalUpgradeNecessary pkgName reason
$logDebug $ T.concat $
[ "Ignoring package "
, packageNameText (fst (lhPair lh))
] ++
maybe [] (\db -> [", from ", T.pack (show db), ","]) mdb ++
["Ignoring package ", pkgName]
++
maybe [] (\db -> [", from ", T.pack (show db), ","]) mdb
++
[ " due to"
, case reason of
Allowed -> " the impossible?!?!"
Expand All @@ -218,6 +220,14 @@ processLoadResult mdb _ (reason, lh) = do
]
return Nothing

warnIfCabalUpgradeNecessary :: MonadLogger m => T.Text -> Allowed -> m ()
warnIfCabalUpgradeNecessary pkg reason = do
let msg = "Cabal version mismatch detected. Try running 'stack setup --upgrade-cabal'"
case reason of
WrongVersion _ _ -> when (pkg == T.pack "Cabal") $ do
$logWarn msg
_ -> return ()

data Allowed
= Allowed
| NeedsProfiling
Expand Down