fix hlint suggestions from hlint-2.0.13#3774
Merged
mgsloan merged 1 commit intocommercialhaskell:masterfrom Jan 15, 2018
Merged
fix hlint suggestions from hlint-2.0.13#3774mgsloan merged 1 commit intocommercialhaskell:masterfrom
mgsloan merged 1 commit intocommercialhaskell:masterfrom
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like a new version of hlint has added some suggestions for our code, which is causing CI failures for PRs (eg #3763 and #3761)
This applies the changes hlint suggests.
They all appear to be
(blah . foo) <$> something====>blah . foo <$> somethingCan't say this seems like the most important suggestion ever, but it seems equally readable before and after, so this seems like the easiest way to shut hlint up unless someone has an objection.