Don't recompile in presence of sublibraries#3955
Merged
snoyberg merged 15 commits intocommercialhaskell:masterfrom Apr 17, 2018
mihaimaruseac:mm-stack-internal-libs
Merged
Don't recompile in presence of sublibraries#3955snoyberg merged 15 commits intocommercialhaskell:masterfrom mihaimaruseac:mm-stack-internal-libs
snoyberg merged 15 commits intocommercialhaskell:masterfrom
mihaimaruseac:mm-stack-internal-libs
Conversation
…clause to be reused next
…ere clause to be reused next
|
@mgsloan, can this be merged/released sooner rather than later? Full rebuilds on every action are a huge pain. |
|
Agreed. This is killing my productivity. |
Member
Author
|
If there's any need for more work on this, I'd be happy to do it. |
Contributor
|
Sorry for the delay on reviewing this. Two comments:
Thank you for this PR! |
Member
Author
|
Sure. I'll do both this week. |
Member
Author
|
And done, was easier than expected to add the test. |
borsboom
pushed a commit
that referenced
this pull request
Apr 17, 2018
Don't recompile in presence of sublibraries (cherry picked from commit a3a8754)
Contributor
|
I've cherry-picked into the |
mihaimaruseac
referenced
this pull request
in haskell/haddock
Apr 17, 2018
A practical benefit is that we can control the build-depends and also avoid some recompilation between library and test-suite.
Contributor
|
@borsboom can we get a |
Contributor
Contributor
|
@borsboom Thanks! 🙂 Update: confirmed that this fixes the rebuilding. |
2 tasks
MonoidMusician
added a commit
to eviefp/caudex
that referenced
this pull request
May 25, 2018
Note: use latest stack (1.7.1) to avoid problems with recompiling all haddock/pandoc: commercialhaskell/stack#3955
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!
Tested first with the
internal-librariespackage mentioned in #3899 (comment) and made Stack not ignore the internal library in this case.Furthermore, tested against my own
hakyll-based repo, to reproduce #3899.