use proper $PATH (with GHC available) doing source map hashing#4467
Merged
use proper $PATH (with GHC available) doing source map hashing#4467
Conversation
snoyberg
approved these changes
Dec 27, 2018
Contributor
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
Can confirm it works locally, thanks for the quick fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
Fixes #4466
I'm not quite sure how to cover this in tests: it appears that currently our integration tests don't clean
$PATHand making that looks to be a noticeable effort: for that we need to check all of the current integration tests and fix any that will fail. @snoyberg I guess it makes sense to do that in a separate issue?