Conversation
This reverts commit 59acc7d.
Prevent all-in-one build only for not yet installed library when test failures are expected
|
The last rebuild took so it looks more or less OK and #4550 should improve it a bit more |
snoyberg
left a comment
There was a problem hiding this comment.
I've looked this over and discussed with @qrilka. This all looks good to me. Only concern is whether mutable packages trigger rebuilds appropriately. Recommendation: add an integration test that works as following:
- Mutable, local copy of a package like
filepathinextra-deps - Single local package that depends on a package in the snapshot which uses
filepath - Perform a non-profiling build
- Perform a profiling build
This will necessitate rebuilding all three packages (filepath, the one depending on it, and the local package). If this works, then we're good.
|
@snoyberg looks like I found a problem which is a bit related to removing of
I will work on fixing this (and will add a test for that of course) |
Also includes a test for this functionality
|
Fixed rebuilds and added 2 integration tests |
Please include the following checklist in your PR:
Tested using the latest Stackage snapshot builds.
Fixes #4217
This mostly changes
curatorcode but also adds extra tweaks into Stack's code to deal properly with expected test and benchmark failures