Conversation
qrilka
left a comment
qrilka
left a comment
There was a problem hiding this comment.
Other than the couple of comments it looks OK to me
| url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/13/9.yaml | ||
| sha256: 83de9017d911cf7795f19353dba4d04bd24cd40622b7567ff61fc3f7223aa3ea | ||
|
|
||
| compiler: ghc-X.Y.Z |
There was a problem hiding this comment.
What about global ghc option ? Shouldn't it be also present ?
There was a problem hiding this comment.
what do you mean by global here?
There was a problem hiding this comment.
@qrilka Probably global is the wrong word here. stack.yaml obtains ghc-option for the package. Should that option be present here in the lock file ?
There was a problem hiding this comment.
GHC options get applied per package, why do we need them here?
There was a problem hiding this comment.
There may be one corner case we need to consider: ghc-options applied to all packages. However, I think that will be addressed by the approach described here.
3 participants
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!