Skip to content

Avoid a warning for names in snapshots#4606

Merged
snoyberg merged 1 commit intomasterfrom
no-name-warning
Mar 6, 2019
Merged

Avoid a warning for names in snapshots#4606
snoyberg merged 1 commit intomasterfrom
no-name-warning

Conversation

@snoyberg
Copy link
Copy Markdown
Contributor

@snoyberg snoyberg commented Mar 6, 2019

Since we no longer require this field, the previous code would spit out
a warning if it was present. This is extremely noisy for a field that
used to be required. Instead: just ignore the field if present.

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

Since we no longer require this field, the previous code would spit out
a warning if it was present. This is extremely noisy for a field that
used to be required. Instead: just ignore the field if present.
@snoyberg snoyberg merged commit a10760e into master Mar 6, 2019
@snoyberg snoyberg deleted the no-name-warning branch March 7, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants