Fix integration test for mutable-deps#4612
Merged
snoyberg merged 2 commits intocommercialhaskell:masterfrom Mar 7, 2019
Merged
Fix integration test for mutable-deps#4612snoyberg merged 2 commits intocommercialhaskell:masterfrom
snoyberg merged 2 commits intocommercialhaskell:masterfrom
Conversation
Without this, this results in an build error like this:
``` shellsession
$ ./run-single-test.sh mutable-deps
Running test mutable-deps
Running: /home/sibi/.local/bin/stack build
directory-1.3.0.2: unregistering (missing dependencies: filepath)
filemanip-0.3.6.3: unregistering (missing dependencies: directory, filepath)
filepath-1.4.1.2: unregistering (local file changes: System/FilePath/Internal.hs)
files-1.0.0: unregistering (missing dependencies: filemanip)
filepath-1.4.1.2: configure (lib)
filepath-1.4.1.2: build (lib)
-- While building package filepath-1.4.1.2 using:
/home/sibi/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_2.0.1.0_ghc-8.2.2 --builddir=.stack-work/dist/x86_64-linux/Cabal-2.0.1.0 build lib:filepath --ghc-options " -ddump-hi -ddump-to-file"
Process exited with code: ExitFailure 1
Logs have been written to: /home/sibi/github/stack/test/integration/tests/mutable-deps/files/.stack-work/logs/filepath-1.4.1.2.log
Configuring filepath-1.4.1.2...
Preprocessing library for filepath-1.4.1.2..
Building library for filepath-1.4.1.2..
/home/sibi/github/stack/test/integration/tests/mutable-deps/files/filepath-1.4.1.2/System/FilePath/Posix.hs:1:1: error:
File name does not match module name:
Saw: ‘Main’
Expected: ‘System.FilePath.Posix’
|
1 | {-# LANGUAGE CPP #-}
| ^
Main.hs: Exited with exit code: ExitFailure 1
CallStack (from HasCallStack):
error, called at ../../../lib/StackTest.hs:132:14 in main:StackTest
```
Member
Author
|
@qrilka Looking at the current build failure, I see why you added that line now. :-) |
Contributor
|
@psibi this should work - It looks that GHC doesn't like annotations to be combined with Safe mode, see https://ghc.haskell.org/trac/ghc/ticket/10826 |
Member
Author
|
@qrilka Thanks, pushed a new commit fixing this. |
qrilka
approved these changes
Mar 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, this results in an build error like this:
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!