Skip to content

Indicate where git-annex will lead to pantry error#4615

Merged
snoyberg merged 1 commit intocommercialhaskell:masterfrom
dbaynard:4579-git-annex-no-support
Mar 26, 2019
Merged

Indicate where git-annex will lead to pantry error#4615
snoyberg merged 1 commit intocommercialhaskell:masterfrom
dbaynard:4579-git-annex-no-support

Conversation

@dbaynard
Copy link
Copy Markdown
Contributor

@dbaynard dbaynard commented Mar 9, 2019

Fixes #4579.

I haven't updated the changelog; not sure where the update should go.

For tests, I could create an integration test which makes a git repo and creates a symbolic link out of the repo. It wouldn't need git-annex, but it would trigger the same error. Does that sound worthwhile?


Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@qrilka
Copy link
Copy Markdown
Contributor

qrilka commented Mar 11, 2019

@dbaynard I think it would be good to have such a test. Otherwise the PR looks fine to me.

@dbaynard
Copy link
Copy Markdown
Contributor Author

OK, it might be the weekend before I get a chance to look at this. If there's pressure to merge first, I'll submit another PR with the test.

@snoyberg
Copy link
Copy Markdown
Contributor

I'm OK with this as-is, merging. Thanks!

@snoyberg snoyberg merged commit 8437ef6 into commercialhaskell:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pantry does not work with git annex

3 participants