Initialize custom-setup deps for stack dist#5461
Merged
Conversation
Contributor
Author
|
@snoyberg one thing which I'm not quite sure about is removing that option - this makes this PR not backwards compatible. Do we need to do some "deprecation" step before removing it? |
This `explicit-setup-deps` unnecessary and thus it was removed
qrilka
force-pushed
the
4006-setup-custom-setup-deps
branch
from
339b525 to
3464638
Compare
snoyberg
approved these changes
Dec 21, 2020
Contributor
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
LGTM. I think it's OK to remove the option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4006
This
explicit-setup-depsunnecessary and thus it was removedNote: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Tested manually