Skip to content

fix(svg): fixes the bug in Svg props #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stuarthendren merged 1 commit into from
Oct 4, 2022
Merged

fix(svg): fixes the bug in Svg props #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/Svg/Svg.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,19 @@ const StyledSvg = styled(DEFAULT_TAG, {
})

type SvgVariants = VariantProps<typeof StyledSvg>
type SvgProps = ComponentProps<typeof DEFAULT_TAG> &
type SvgProps = Omit<ComponentProps<typeof DEFAULT_TAG>, 'fr'> &
CSSProps &
SvgVariants & {
/** Add a title to the svg */
title?: string
/** Add the given svg path */
path?: string
/**
* The fr attribute defines the radius of the focal point for the radial gradient.
*
* Forced optional due to ts bug
*/
fr?: string
}

/**
Expand Down