logging improvements #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bmonkman
commented
Mar 11, 2021
bmonkman
commented
- enhancement: Added request id logging, added logging for 4xx errors since they weren't caught by route-specific logging
- enhancement: Added the ability to dump request content for debugging
…ince they weren't caught by route-specific logging
davidcheung
approved these changes
Mar 12, 2021
Co-authored-by: David Cheung <davidcheung@live.ca>
dtoki
pushed a commit
to dtoki/zero-notification-service
that referenced
this pull request
Apr 9, 2021
* enhancement: Added request id logging, added logging for 4xx errors since they weren't caught by route-specific logging * enhancement: Added the ability to dump request content for debugging * Update internal/log/ecs.go Co-authored-by: David Cheung <davidcheung@live.ca> Co-authored-by: David Cheung <davidcheung@live.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.