enhancement: Added the ability to configure a list of domains and only send mail to addresses in those domains #21
Conversation
…y send mail to addresses in those domains
internal/mail/mail.go
Outdated
| func RemoveInvalidRecipients(recipients []server.EmailRecipient, allowedDomains []string) []server.EmailRecipient { | ||
| valid := []server.EmailRecipient{} | ||
| for _, recipient := range recipients { | ||
|
|
davidcheung
left a comment
davidcheung
left a comment
There was a problem hiding this comment.
I think RESTRICT_EMAIL_TO_DOMAINS might be a little more clear, but with the description i think is good enough
|
That's what I used originally, but I changed it because I found "Restrict" to be a little more ambiguous. Does it mean emails are restricted from going to those domains or restricted to going to anything that's not those domains? |
|
How about |
|
Right now it's |
1 similar comment
|
Right now it's |
|
👍 Yeah i think either way once the user reads the description the behavior will be apparent, |
…y send mail to addresses in those domains (commitdev#21) * enhancement: Added the ability to configure a list of domains and only send mail to addresses in those domains * Added env var docs * Updated helm chart
3 participants
A comma separated list of domains can now be specified as an env var, and email sending (including to, cc, bcc) will be restricted to only addresses in those domains.