fix: Properly split domains on comma, viper doesn't do it for env vars #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcheung
reviewed
Mar 12, 2021
| // Split the string on commas, viper doesn't support doing this to env vars | ||
| domains := []string{} | ||
| if viper.GetString(AllowEmailToDomains) != "" { | ||
| domains = strings.Split(viper.GetString(AllowEmailToDomains), ",") |
Contributor
There was a problem hiding this comment.
would we need to trim the domains? many people type coma separated list with a space in between
Contributor
Author
There was a problem hiding this comment.
Since it's an env var you would have to quote it to even put a space into it, and if you use the config via zero-aws-eks-stack it creates the contents of this env var automatically using TF and helm. I'll trim it too though, might as well.
Contributor
There was a problem hiding this comment.
oh right 👍 , didnt see the usage from the infra PR at the time
yeah so will never really have that problem in our setup
davidcheung
approved these changes
Mar 12, 2021
davidcheung
approved these changes
Mar 12, 2021
dtoki
pushed a commit
to dtoki/zero-notification-service
that referenced
this pull request
Apr 9, 2021
commitdev#22) * fix: Properly split domains on comma, viper doesn't do it for env vars * Trim spaces from domains in allow list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.