Refactor loading modules and creating project data #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split prompting into a few smaller, more specific functions Split module tests into internal and external
bmonkman
commented
Jun 5, 2020
| projectParameters := promptAllModules(moduleConfig) | ||
| for _ = range projectParameters { | ||
| // TODO: Add parameters to module structs inside project | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Being able to call these functions and have a list of all the module configs keyed by module name, and all parameters filled by the user was the core of this refactor, as all this information is required by other logic to come in this function.
bmonkman
commented
Jun 5, 2020
| return &projectConfig | ||
| } | ||
|
|
||
| func promptAllModules(projectConfig *projectconfig.ZeroProjectConfig) { |
Contributor
Author
There was a problem hiding this comment.
This did too much stuff.
bmonkman
commented
Jun 5, 2020
| } | ||
| templateModules = append(templateModules, mod) | ||
| } | ||
| // Initiate all the modules defined in the config |
Contributor
Author
There was a problem hiding this comment.
Commented out until we work on generation.
bmonkman
commented
Jun 5, 2020
| if !IsLocal(templateModule.Source) { | ||
| err := getter.Get(sourcePath, templateModule.Source, getter.WithProgress(p)) | ||
| // FetchModule downloads the remote module source (or loads the local files) and parses the module config yaml | ||
| func FetchModule(source string) (moduleconfig.ModuleConfig, error) { |
Contributor
Author
There was a problem hiding this comment.
Now accepts a single module source (directory or url) and returns the config of that project.
bmonkman
commented
Jun 5, 2020
| } | ||
|
|
||
| // TODO : Use this function signature instead | ||
| func PromptParams(moduleConfig moduleconfig.ModuleConfig, parameters map[string]string) (map[string]string, error) { |
Contributor
Author
There was a problem hiding this comment.
This is for David, you'll have to tie your refactoring in here.
davidcheung
approved these changes
Jun 5, 2020
Preserve backward compatibility Co-authored-by: David Cheung <davidcheung@live.ca>
dtoki
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split prompting into a few smaller, more specific functions
Split module tests into internal and external