#134 Add prompts for project names #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmonkman
commented
Jun 9, 2020
| // @TODO : Uncomment when this struct is implemented | ||
| repoName := prompts[moduleName].GetParam(initParams) | ||
| repoURL := fmt.Sprintf("%s/%s", initParams["GithubRootOrg"], repoName) | ||
| //projectConfig.Modules[moduleName].Files.Directory = prompts[moduleName].GetParam(initParams) |
Contributor
Author
There was a problem hiding this comment.
I'll uncomment this after Thiago's PR is merged.
bmonkman
commented
Jun 9, 2020
| wg := sync.WaitGroup{} | ||
| wg.Add(len(moduleSources)) | ||
| for _, moduleSource := range moduleSources { | ||
| go module.FetchModule(moduleSource, &wg) |
Contributor
Author
There was a problem hiding this comment.
Fetching will be done in parallel now
bmonkman
commented
Jun 9, 2020
|
|
||
| for _, moduleSource := range moduleSources { | ||
| mod, err := module.FetchModule(moduleSource) | ||
| mod, err := module.ParseModuleConfig(moduleSource) |
Contributor
Author
There was a problem hiding this comment.
Split the parsing out from the fetching
bmonkman
commented
Jun 9, 2020
| Modules []string | ||
| Name string | ||
| ShouldPushRepositories bool | ||
| Infrastructure Infrastructure // TODO simplify and flatten / rename? |
Contributor
Author
There was a problem hiding this comment.
Gonna remove this Infrastructure struct entirely in another PR
davidcheung
reviewed
Jun 10, 2020
| repoURL := fmt.Sprintf("%s/%s", initParams["GithubRootOrg"], repoName) | ||
| //projectConfig.Modules[moduleName].Files.Directory = prompts[moduleName].GetParam(initParams) | ||
| //projectConfig.Modules[moduleName].Files.Repository = repoURL | ||
| fmt.Println(repoURL) |
Contributor
Author
There was a problem hiding this comment.
Yeah, reminder that that code needs to be filled in.
davidcheung
reviewed
Jun 10, 2020
| type PromptHandler struct { | ||
| moduleconfig.Parameter | ||
| Condition func(map[string]string) bool | ||
| Validate func(string) error |
Contributor
There was a problem hiding this comment.
🎉 maybe later on we can implement some type of openapi schema validation, then user can supply that on the module side and we can consume from Parameter struct as well
davidcheung
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.