Marshal zero-project.yaml file #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dtoki merged 8 commits into master from zero-130

Jun 23, 2020

Contributor

dtoki commented Jun 17, 2020 •

edited

Loading

Pending:
~~Util function to properly indent the modules.~~
~~Asserts statements on TestGetProjectFileContent~~

Closes #130

dtoki requested a review from bmonkman

June 17, 2020 21:11

dtoki marked this pull request as draft

June 17, 2020 21:19

dtoki requested a review from davidcheung

June 17, 2020 21:21

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/util/util.go Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

bmonkman suggested changes

View reviewed changes

Contributor

bmonkman left a comment

Review done for now.

bmonkman reviewed

View reviewed changes

internal/util/util.go Outdated Show resolved Hide resolved

dtoki force-pushed the zero-130 branch from 3fb3826 to 5ee3b64 Compare

June 19, 2020 22:18

bmonkman reviewed

View reviewed changes

internal/util/util.go Outdated Show resolved Hide resolved

bmonkman reviewed

View reviewed changes

internal/config/projectconfig/init.go Outdated Show resolved Hide resolved

dtoki force-pushed the zero-130 branch from 5ee3b64 to 0f53d55 Compare

June 20, 2020 01:43

dtoki marked this pull request as ready for review

June 23, 2020 01:51

dtoki commented

View reviewed changes

internal/config/projectconfig/init_test.go Outdated Show resolved Hide resolved

dtoki requested a review from bmonkman

June 23, 2020 02:03

dtoki changed the title ~~[WIP] Marshal zero-project.yaml file~~ Marshal zero-project.yaml file

bmonkman approved these changes

View reviewed changes

dtoki added 6 commits

June 23, 2020 12:29


          wip: marshal zero-project.yaml file

1110bda


          properly indent module configs

eb70856

init.go clean-up


          use string instead of byte buffer

1d8e551


          clean up tests and error handling

f91fa2c


          refactor

a153e26


          unmarshal for testing

d362573


          * refactor project_config/init.go

* change test location

dtoki force-pushed the zero-130 branch from a3bcdce to e283d99 Compare

June 23, 2020 19:41


          test when moudules is empty.

22fa36a

rebase from master.

dtoki force-pushed the zero-130 branch from e283d99 to 22fa36a Compare

June 23, 2020 19:43

dtoki merged commit 325a6c4 into master

dtoki deleted the zero-130 branch

June 24, 2020 16:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet