Integrate apply command #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stream apply output Changed apply test to compare a file rather than output Changed prompts to use til for appending env Added handling for relative paths during execution Append env from outside zero when running commands inside Changed to execute makefile in module dir, not project dir
bmonkman
commented
Jun 23, 2020
| } | ||
|
|
||
| // AsEnvVars marshals ProjectCredential as a map of key/value strings suitable for environment variables | ||
| func (p ProjectCredential) AsEnvVars() map[string]string { |
davidcheung
reviewed
Jun 23, 2020
Contributor
Author
|
Weird, dunno how this got closed. Must have been something I did in zenhub. Sorry. |
dtoki
reviewed
Jun 24, 2020
| @@ -0,0 +1,19 @@ | |||
| name: sample_project | |||
|
|
|||
| context: | |||
Contributor
There was a problem hiding this comment.
According to the new zero-project.yaml spec do we still support the context: field?
dtoki
reviewed
Jun 24, 2020
Comment on lines
+23
to
+25
| if strings.Trim(configPath, " ") == "" { | ||
| exit.Fatal("config path cannot be empty!") | ||
| } |
Contributor
There was a problem hiding this comment.
Would it be better to return the error in this case and let the caller throw the error for consistency like initin #130?
Contributor
There was a problem hiding this comment.
Nvm, I just realized your comment was specific to if I wanted to test the error case so I guess that doesn't apply here because it's not a standard we're enforcing.
davidcheung
approved these changes
Jun 24, 2020
dtoki
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to get the apply command working including passing more required env vars in and correcting some of the paths.