Skip to content

Zero root domain static site support #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dtoki merged 3 commits into from
Aug 18, 2020
Merged

Zero root domain static site support #231

dtoki merged 3 commits into from
Aug 18, 2020

Conversation

@dtoki
Copy link
Contributor

@dtoki dtoki commented Aug 13, 2020 •
edited
Loading

Adds zero landing page registry

  • add a new repo to zero registry

Don't template binary files.

  • Considering the definition of a binary file as "a computer file that is not a text file", they can be differentiated by searching for the text/plain MIME in its MIME hierarchy.

closes #229

bmonkman
bmonkman reviewed Aug 14, 2020
View reviewed changes
bmonkman
bmonkman reviewed Aug 14, 2020
View reviewed changes
@dtoki dtoki changed the title Fixes templating bug #229 Zero root domain static site support Aug 14, 2020
@dtoki dtoki marked this pull request as ready for review August 14, 2020 01:45
@dtoki dtoki assigned davidcheung and bmonkman and unassigned bmonkman and davidcheung Aug 14, 2020
@dtoki dtoki requested review from bmonkman and davidcheung August 14, 2020 12:59
@dtoki dtoki self-assigned this Aug 14, 2020
bmonkman
bmonkman approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@bmonkman bmonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@dtoki dtoki merged commit b38e72a into master Aug 18, 2020
@dtoki dtoki deleted the 222-laning-page branch August 18, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidcheung davidcheung Awaiting requested review from davidcheung

1 more reviewer

@bmonkman bmonkman bmonkman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dtoki dtoki

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zero create step fails on templating a non-text file located in a directory

4 participants

@dtoki @bmonkman @davidcheung