Skip to content

Add Wget dependency #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtoki merged 2 commits into from
Aug 20, 2020
Merged

Add Wget dependency #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a459d5
add wget dependency
dtoki Aug 19, 2020
5a75e12
* bump terraform version
dtoki Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,7 @@ brews:
type: optional
- name: kubectl
type: optional
- name: wget
type: optional
test: |
system "#{bin}/zero version"
10 changes: 9 additions & 1 deletion cmd/check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ var checkCmd = &cobra.Command{
command: "terraform",
args: []string{"version"},
regexStr: `Terraform v(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)`,
minVersion: "0.12.0",
minVersion: "0.13.0",
docsURL: "https://www.terraform.io/downloads.html",
},
{
Expand All @@ -143,6 +143,14 @@ var checkCmd = &cobra.Command{
minVersion: "2.17.1",
docsURL: "https://git-scm.com/book/en/v2/Getting-Started-Installing-Git",
},
{
Copy link
Contributor

@davidcheung davidcheung Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also bump the terraform to 0.13 please, the EKS stack's terraforms are now using some 0.13 features

name: "Wget\t\t",
command: "wget",
args: []string{"--version"},
regexStr: `^GNU Wget (0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)`,
minVersion: "1.14.0",
docsURL: "https://www.gnu.org/software/wget/",
},
}

// Store and errors from the commands we run.
Expand Down