Skip to content

fix docker files & http generation for docker compose #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pritesh-Patel merged 1 commit into from
Oct 12, 2019
Merged

fix docker files & http generation for docker compose #27

Pritesh-Patel merged 1 commit into from
Oct 12, 2019

Conversation

@Pritesh-Patel
Copy link
Contributor

@Pritesh-Patel Pritesh-Patel commented Oct 12, 2019 •
edited
Loading

Fixs to unblock #23, general docker fixs.

  • Http Gateway now takes env vars or falls backs to defaults
  • Fixed go build commands in docker file

ShahNewazKhan
ShahNewazKhan approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@ShahNewazKhan ShahNewazKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pritesh-Patel Pritesh-Patel merged commit 4772126 into master Oct 12, 2019
@bmonkman bmonkman deleted the docker-http-fix branch November 5, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihailistov mihailistov Awaiting requested review from mihailistov

1 more reviewer

@ShahNewazKhan ShahNewazKhan ShahNewazKhan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pritesh-Patel @ShahNewazKhan