Skip to content

fix: typo in module reference #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmonkman merged 1 commit into from
Aug 18, 2021
+4 −4
Merged

fix: typo in module reference #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/config/moduleconfig/module_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"reflect"
"strings"

goVerson "github.com/hashicorp/go-version"
goVersion "github.com/hashicorp/go-version"
yaml "gopkg.in/yaml.v2"

"github.com/commitdev/zero/internal/config/projectconfig"
Expand Down Expand Up @@ -38,7 +38,7 @@ type ModuleCommands struct {
}

func checkVersionAgainstConstrains(vc VersionConstraints, versionString string) bool {
v, err := goVerson.NewVersion(versionString)
v, err := goVersion.NewVersion(versionString)
if err != nil {
return false
}
Expand Down Expand Up @@ -100,7 +100,7 @@ type TemplateConfig struct {
}

type VersionConstraints struct {
goVerson.Constraints
goVersion.Constraints
}

// A "nice" wrapper around findMissing()
Expand Down Expand Up @@ -273,7 +273,7 @@ func (semVer *VersionConstraints) UnmarshalYAML(unmarshal func(interface{}) erro
return err
}
if versionString != "" {
constraints, constErr := goVerson.NewConstraint(versionString)
constraints, constErr := goVersion.NewConstraint(versionString)
// If an invalid constraint is declared in a module
// instead of erroring out we just print a warning message
if constErr != nil {
Expand Down