COMMIT0-57 api for generating project #68
Conversation
liang-lillian
force-pushed
the
COMMIT0-57-api
branch
2 times, most recently
from
84cb805 to
51a3d15
Compare
| case "POST": | ||
| decoder := json.NewDecoder(req.Body) | ||
| var projectConfig ProjectConfiguration | ||
| err := decoder.Decode(&projectConfig) |
There was a problem hiding this comment.
need to add validation for post request
internal/api/create_project.go
Outdated
| templates := packr.New("templates", "../templates") | ||
| t := templator.NewTemplator(templates) | ||
|
|
||
| err := os.Chdir(projectConfig.ProjectName) //cd into project |
There was a problem hiding this comment.
cd into project
(could pass in project name to add to file path for each generate function)
There was a problem hiding this comment.
Yeah you shouldn't need to chdir..
internal/api/README.md
Outdated
|
|
||
| ## Usage | ||
| - To run: | ||
| `go run internal/api/generate_api.go internal/api/create_project.go` |
There was a problem hiding this comment.
Let's change this to an argument to the binary. commit0 walkthrough or commit0 ui or something
There was a problem hiding this comment.
Yeah you would create a new file like cmd/ui.go which adds a new command
internal/generate/generate_helper.go
Outdated
| "sync" | ||
| ) | ||
|
|
||
| func GenerateArtifactsHelper(t *templator.Templator, cfg *config.Commit0Config) { |
There was a problem hiding this comment.
shared func for both cmd / api generate
internal/api/create_project.go
Outdated
| if (err != nil) { | ||
| panic(err) | ||
| } | ||
| cfg := config.LoadConfig(util.ApiGeneratedYamlName) |
There was a problem hiding this comment.
Let's just keep calling this commit0.yaml?
internal/templator/templator.go
Outdated
| ProtoHealthTemplate: NewSingleFileTemplator(box, "proto/health_proto.tmpl"), | ||
| ProtoServiceTemplate: NewSingleFileTemplator(box, "proto/service_proto.tmpl"), | ||
| Go: NewGoTemplator(box), | ||
| ApiCommit0: NewSingleFileTemplator(box, "commit0/api_generated.tmpl"), |
There was a problem hiding this comment.
The output of the ui process should just be a regular commit0.yaml using the same template
liang-lillian
force-pushed
the
COMMIT0-57-api
branch
from
5073edb to
262df53
Compare
No description provided.