Issue #59: Implement poc ui #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zthomas
reviewed
Nov 30, 2019
internal/ui/src/App.css
Outdated
|
|
||
| .App-link { | ||
| color: #09d3ac; | ||
| } |
Contributor
There was a problem hiding this comment.
Doesn't look like this file is still being used.
Contributor
Author
There was a problem hiding this comment.
Just the text-align, moved to index.css
zthomas
reviewed
Nov 30, 2019
| code { | ||
| font-family: source-code-pro, Menlo, Monaco, Consolas, "Courier New", | ||
| monospace; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Yes, it sets the font for the material ui components.
zthomas
suggested changes
Nov 30, 2019
Contributor
zthomas
left a comment
zthomas
left a comment
There was a problem hiding this comment.
Awesome, it's a great start. I tested it on my local and it worked 👌 I just have a few comments about cleaning up any unused css. When we use MUI there's really not much need for global CSS.
zthomas
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a web-ui for creating projects.