Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+46
to
+51
| foreach (var ngo in ngosToAddAsMonitoringNgos) | ||
| { | ||
| var monitoringNgo = electionRound.AddMonitoringNgo(ngo); | ||
| monitoringNgos.Add(monitoringNgo); | ||
| context.MonitoringNgos.Add(monitoringNgo); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select
Comment on lines
+45
to
+50
| foreach (var ngo in ngosToAddAsMonitoringNgos) | ||
| { | ||
| var monitoringNgo = coalition.ElectionRound.AddMonitoringNgo(ngo); | ||
| coalitionMembers.Add(monitoringNgo); | ||
| context.MonitoringNgos.Add(monitoringNgo); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select
| && x.MonitoringNgo.NgoId == req.NgoId | ||
| && x.Id == req.FormId) | ||
| .FromSqlInterpolated($""" | ||
| select f.* from "GetAvailableForms"({req.ElectionRoundId}, {req.NgoId}, {req.DataSource.ToString()}) af |
Check notice
Code scanning / CodeQL
Redundant ToString() call
| """; | ||
|
|
||
| var queryArgs = new { electionRoundId = req.ElectionRoundId, ngoId = req.NgoId }; | ||
| IEnumerable<MonitoringObserverExportModel> monitoringObservers = []; |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
| PresignedUrl = result!.Url, | ||
| MimeType = attachment.MimeType, | ||
| UrlValidityInSeconds = result.UrlValidityInSeconds, | ||
| UrlValidityInSeconds = result.UrlValidityInSeconds |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
|
|
||
| public CoalitionScenarioBuilder WithQuickReport(ScenarioObserver observer, ScenarioPollingStation pollingStation) | ||
| { | ||
| var observerClient = ParentBuilder.WithQuickReport(observer, pollingStation); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
| @@ -24,6 +24,6 @@ | |||
| new List<object[]> | |||
| { | |||
| new object[] { Guid.Empty }, | |||
| new object[] { null as Guid? }, | |||
| new object[] { null as Guid? } | |||
Check warning
Code scanning / CodeQL
Useless upcast
|
|
||
| {isFiltering && ( | ||
| {filtersExpanded && ( |
Check warning
Code scanning / CodeQL
Useless conditional
| const { data: statistics } = useElectionRoundStatistics(currentElectionRoundId); | ||
|
|
||
| const { data: statistics } = useElectionRoundStatistics(currentElectionRoundId, dataSource); | ||
| console.log(statistics) |
Check notice
Code scanning / CodeQL
Semicolon insertion
idormenco
added a commit
that referenced
this pull request
Nov 27, 2024
* Rename column in form templates (#809) * Reset pageNumber param on filtering (#819) * fix: make dropdown menus scrollable * fix: truncate overflowing table columns * Squashed commit of the following: commit 742f250 Author: imdeaconu <imdeaconu@gmail.com> Date: Wed Sep 11 19:54:55 2024 +0300 add read notification checkmark commit ea11fa0 Author: imdeaconu <imdeaconu@gmail.com> Date: Wed Sep 11 19:54:30 2024 +0300 add read notification column * Squashed commit of the following: commit d8833dc Author: imdeaconu <imdeaconu@gmail.com> Date: Fri Sep 13 13:29:31 2024 +0300 WIP: add selector functionality commit 3608c0e Author: imdeaconu <imdeaconu@gmail.com> Date: Fri Sep 13 10:00:05 2024 +0300 WIP: create new tags input * chore: remove unused import * chore: delete duplicated / unused classes * feature: add searching to MonitoringObserversTagFilter * chore: update config files * Revert "[NGO Admin] Rewrite the tag selector component (#675)" This reverts commit 2ad0e90. * Merge branch 'main' of https://github.com/commitglobal/votemonitor into commitglobal-main * reset page numbr to 1 on filtering * Update Endpoint.cs (#820) * Update Endpoint.cs (#821) * Release v0.2.33 (#822) * NGO coalitions (#823) * Add coalitions * Fix form template name, fix get form by id and form submissions * fix selects * Add form access ui * Remove unused columns * Fix get filters * Add data source filters for submissions * Fix list submissions * fix queries * fixes and tests * cleanup, fix list by observer endpoint add tests * refactor fix tests * fix tests and selects * fix queries for get by id and get aggregated * Fix quick reports * implement coalition data * add is own observer and filters on qr * Fix failing tests * fix ui build * fix statistics * fix issues * fix tests * Release v0.2.34 (#824) * Improve UX for election round selector (#825) * Fix export data as coalition member (#826) * Update locals.tf (#827) * Fix sendind notifications (#828) * Release v0.2.36 (#829) * Fix sending of notifications (#830) * Release v0.2.37 (#831) * Feature/rework header (#833) * Rework header * Fix bug with invitations * Fix stuff * Release v0.2.38 (#834) * add readonly view (#835) * Release v0.2.39 (#836) * Fix number of targeted observers (#837) * Release v0.2.40 (#838) * Feature/cleanup (#839) * Cleanup and improvements * move form submissions to /responses/form-submissions * add before load for all auth routes * Rework and cleanup observers import * cleanup --------- Co-authored-by: Iulian Deaconu <imdeaconu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.