[Citizen Reporting Web] Bugfixes and improvements for the reporting form component#960
Merged
idormenco merged 7 commits intocommitglobal:feature/citizen-reporting-webfrom May 27, 2025
Conversation
Contributor
imdeaconu
commented
Apr 28, 2025
imdeaconu
commented
- fixed number, text and multiselect questions resetting if the user went back to the previous step
- fixed validation triggering early (after location is selected)
- changed the validation mode to onChange so we can validate both when the user enters data and on submit
- fixed validation for number questions and added a new component for number inputs
…input losing the value when going back
|
@imdeaconu is attempting to deploy a commit to the Code for Romania Team on Vercel. A member of the Team first needs to authorize it. |
idormenco
requested changes
Apr 29, 2025
* start refactoring inputs * fix multiselect and add free text responses * refactor display logic check * refactor and set required only if field is displayed * refactor logic * add freeform text to single select input * add rating input
idormenco
merged commit e9fb9a0
into
commitglobal:feature/citizen-reporting-web
1 check failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.