Skip to content

fix: bug where one missing address column would fail geocoding, even when other columns exist #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquimds merged 2 commits into from
Feb 19, 2026
Merged

fix: bug where one missing address column would fail geocoding, even when other columns exist #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de75ecf
fix: bug where one missing address column would fail geocoding, even …
joaquimds Feb 19, 2026
fb9c1da
Update src/server/mapping/geocode.ts
joaquimds Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/app/(private)/data-sources/[id]/components/GeocodingConfigFields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ export function GeocodingConfigFields({
}
};

// Include previous options that are no longer in the data source column defs, so they can be removed
const allOptions = Array.from(
new Set(locationColumnOptions.map((c) => c.label).concat(columns)),
);

return (
<>
<CustomSelect
Expand All @@ -114,7 +119,7 @@ export function GeocodingConfigFields({
<CustomMultiSelect
id="config-location-columns-multi"
label="Location columns"
allOptions={dataSource?.columnDefs.map((cd) => cd.name)}
allOptions={allOptions}
selectedOptions={columns}
onChange={onDropdownChange}
/>
Expand Down
9 changes: 5 additions & 4 deletions src/server/mapping/geocode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,11 @@ const geocodeRecordByAddress = async (
) => {
const dataRecordJson = dataRecord.json;
const { columns: addressColumns } = geocodingConfig;
for (const addressColumn of addressColumns) {
if (!(addressColumn in dataRecordJson)) {
throw new Error(`Missing area column "${addressColumn}" in row`);
}
const hasColumn = addressColumns.some((c) => c in dataRecordJson);
if (!hasColumn) {
throw new Error(
`Missing address columns "${addressColumns.join(", ")}" in row`,
);
}

// TODO: remove UK when other countries are supported
Expand Down