Optimize parsing: Tight/loose lists and small things #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure optimization would take care of that, but doing it doesn't really hurt readability either.
I'll conclude that this was a failed experiment. Benchmarks show that performance improves up to 4% when we remove it.
This results in an almost 10% performance improvement on both benchmarks. Before: Benchmark Mode Cnt Score Error Units SpecBenchmark.examples thrpt 200 308.071 ± 0.975 ops/s SpecBenchmark.wholeSpec thrpt 200 134.033 ± 0.545 ops/s After: SpecBenchmark.examples thrpt 200 331.033 ± 0.930 ops/s SpecBenchmark.wholeSpec thrpt 200 146.443 ± 0.584 ops/s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling showed that code for tight/loose list calculation was using a bunch of time. Rewriting that resulted in another nice performance improvement. Before:
After:
That's another 10% to 15% improvement :).