Skip to content

Allow to add inline parsers to built-in implementation #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zampino wants to merge 1 commit into from
Closed

Allow to add inline parsers to built-in implementation #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions commonmark/src/main/java/org/commonmark/internal/InlineParserImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ public Scanner scanner() {
return scanner;
}

public InlineParser addInlineParser(Character c, List<InlineContentParser> parsers) {
this.inlineParsers.put(c, parsers);
Copy link
Collaborator

@robinst robinst Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will currently override any existing built-in parsers with that same special character. I think we should do the same thing as for block parsers, see

commonmark-java/commonmark/src/main/java/org/commonmark/parser/Parser.java

Line 208 in 1bf85c6

public Builder customBlockParserFactory(BlockParserFactory blockParserFactory) {

So try the custom parsers first. The custom parser can decide not to handle something, in which case the built-in parsers are tried next.

this.specialCharacters.set(c);
return this;
}

private static void addDelimiterProcessors(Iterable<DelimiterProcessor> delimiterProcessors, Map<Character, DelimiterProcessor> map) {
for (DelimiterProcessor delimiterProcessor : delimiterProcessors) {
char opening = delimiterProcessor.getOpeningCharacter();
Expand Down