-
Notifications
You must be signed in to change notification settings - Fork 320
Add text content renderer #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| @Override | ||
| public void visit(OrderedList orderedList) { | ||
| orderedListCounter = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use orderedList.getStartNumber() instead of 1, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right :) Fixed here 32771fa
|
Nice change! Do you have any plans for making it work for custom nodes for extensions (e.g. (By the way, I was on holidays, that's why it took so long to respond.) |
|
Thanks for review! I've made the fix with lists. Also I've tried to implement support extensions for TextContentRenderer. But I had to make some changes in core in order to avoid copying of code. You can see it in last 5 commits. Let me know what you think about those changes 😊 |
|
I think your changes are great 😊 |
|
Thanks! Merged now. Will do a release soon with these and other changes. |
|
Released now, thanks a lot @JinneeJ: https://github.com/atlassian/commonmark-java/releases/tag/commonmark-parent-0.7.0 |
Finally added ability to get clean text.
P.S.: Really sorry for big delay 🙏