Add prefix/suffix to ids generated #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds the ability for IdGenerator to be passed in prefixes and suffixes that will ensure to be added in-front/after every id. This will allow users to 'namespace' their generated ids to a certain pool.
devslash-paul
commented
Oct 4, 2016
| .build(); | ||
| } | ||
|
|
||
| public static HeadingIdAttributeProvider create() { |
Author
There was a problem hiding this comment.
I'm pretty sure i should remove this create method. This isn't part of the public API, and will be unused if using the public API
Collaborator
There was a problem hiding this comment.
Yes, feel free to remove it 👍.
robinst
requested changes
Oct 4, 2016
Collaborator
robinst
left a comment
robinst
left a comment
There was a problem hiding this comment.
Looks good, just two minor things to fix and then we can merge this.
| return create(builder()); | ||
| } | ||
|
|
||
| public static Extension create(Builder builder) { |
Collaborator
There was a problem hiding this comment.
This does not need to be public. Instead, just pass the builder to the private constructor. See what we do in HtmlRenderer.
| .build(); | ||
| } | ||
|
|
||
| public static HeadingIdAttributeProvider create() { |
Collaborator
There was a problem hiding this comment.
Yes, feel free to remove it 👍.
robinst
approved these changes
Oct 5, 2016
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that will ensure to be added in-front/after every id. This will
allow users to 'namespace' their generated ids to a certain pool.