Skip to content

Tasks#8

Open
compil3 wants to merge 3 commits intomainfrom
tasks
Open

Tasks#8
compil3 wants to merge 3 commits intomainfrom
tasks

Conversation

@compil3
Copy link
Copy Markdown
Owner

@compil3 compil3 commented Sep 10, 2022

No description provided.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Sep 10, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.56%.

Quality metrics Before After Change
Complexity 156.12 ⛔ 134.80 ⛔ -21.32 👍
Method Length 183.65 😞 186.76 😞 3.11 👎
Working memory 38.18 ⛔ 34.80 ⛔ -3.38 👍
Quality 31.37% 😞 31.93% 😞 0.56% 👍
Other metrics Before After Change
Lines 1346 1424 78
Changed files Quality Before Quality After Quality Change
main.py 75.21% ⭐ 75.19% ⭐ -0.02% 👎
extensions/botutil.py 54.88% 🙂 55.28% 🙂 0.40% 👍
extensions/discord_verifier.py 28.02% 😞 27.05% 😞 -0.97% 👎
extensions/player.py 49.86% 😞 49.91% 😞 0.05% 👍
extensions/queue.py 49.05% 😞 40.61% 😞 -8.44% 👎
utils/stat_builder.py 0.00% ⛔ 0.00% ⛔ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
utils/stat_builder.py PlayerStatsBuilder.builder 355 ⛔ 3134 ⛔ 76 ⛔ 0.00% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
extensions/discord_verifier.py DiscordVerification.create_thread 54 ⛔ 660 ⛔ 22 ⛔ 5.66% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
extensions/queue.py fetch_api 44 ⛔ 202 😞 16 ⛔ 20.37% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
extensions/botutil.py BotInfo.debug_info 10 🙂 572 ⛔ 14 😞 33.65% 😞 Try splitting into smaller methods. Extract out complex expressions
extensions/queue.py Queue.check_queue 15 🙂 255 ⛔ 13 😞 35.76% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant