Install Miri #1631
Merged
Install Miri #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narpfel
force-pushed
the
rust-install-miri
branch
from
1f7def9 to
8e3ee2b
Compare
Member
Member
|
The miri build failed: |
Member
|
@narpfel let me know if I can help with this: I don't really know what's going on there and the error seems to be in |
Member
Author
Building the Miri sysroot needs the standard library sources, which it tries to install, but this doesn’t work because CE’s If you’d prefer that |
Member
|
This will need to be installed in the docker container. The error is in the docker - the docker image doesn't see anything other than the things we place in it. Maybe I'm misunderstanding this: do you mean for the infra package to install something ecxtra just so it appears in the docker container here? |
Member
Author
|
Yes, the build script in the docker container uses the |
Member
|
Now I get it: I think we should only install it in the docker container if that's OK: it already takes hours to install rust things on our slow network drive, adding a ton more on the nightly install (unless it's needed at runtime anyway) just to have it available in the docker seems unfortunate. |
Member
Author
That’s also okay, as far as I know the sources are only needed during build time. It’s not a lot of space, just a lot of small files, so I imagine installing them on a network drive would be rather slow. |
Member
|
Perfect: thanks @narpfel |
Member
Author
|
PR here: compiler-explorer/misc-builder#113 |
Member
|
Merged; and building: https://github.com/compiler-explorer/compiler-workflows/actions/runs/15289645148 |
Member
|
Still failing: https://github.com/compiler-explorer/compiler-workflows/actions/runs/15289645148 can you please run and confirm the docker image runs locally if possible? It will save a lot of long round-trips and is partly why we use docker; it should be fairly straightforward (if computiationally expensive I know) to test locally. |
Member
|
The log file is large- here's the important part: |
Member
Author
I was trying to avoid that (I tested with just a few common (tier 1) targets), but in the end it wasn’t that bad. Builds successfully now. The “fix” was to not abort the whole build if one target fails to build. |
Member
|
thanks @narpfel ! sorry this is so painful |
Member
Member
|
Success!! |
mattgodbolt
approved these changes
May 29, 2025
Member
|
Now to work out why it's not finding the built stuff... |
Member
|
Member
|
|
Member
Author
Thanks! I wasn’t sure if it’s |
Member
well, that didn't work unfortunatlely. I'll fix. the name of the container needs to match the exported name :) It'll be a quick fix |
Member
|
Sorry this is taking so long, a number of subtle issues I didn't spot ... I'll get this in the next day or two for sure though |
Member
|
Finally installed! |
mattgodbolt
pushed a commit
to compiler-explorer/compiler-explorer
that referenced
this pull request
May 30, 2025
Resolves #2563. `misc-builder` PR: compiler-explorer/misc-builder#112 `compiler-workflows` PR: compiler-explorer/compiler-workflows#36 `infra` PR: compiler-explorer/infra#1631 Screenshot: 
21 tasks
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
misc-builderPR: compiler-explorer/misc-builder#112CE issue: compiler-explorer/compiler-explorer#2563