Skip to content

fix(unix,iour): musl libc compatibility#233

Merged
Berrysoft merged 3 commits intocompio-rs:masterfrom
valpackett:musl
Mar 30, 2024
Merged

fix(unix,iour): musl libc compatibility#233
Berrysoft merged 3 commits intocompio-rs:masterfrom
valpackett:musl

Conversation

@valpackett
Copy link
Copy Markdown
Contributor

The libc crate does not provide statx on musl, and msghdr contains private padding fields :(

See also: DataDog/glommio#590


Interestingly I'm getting one test failure on my machine:

---- cancel_before_poll stdout ----
thread 'cancel_before_poll' panicked at compio-driver/tests/file.rs:72:24:
index out of bounds: the len is 0 but the index is 0

The libc crate does not provide statx on musl, and msghdr contains
private padding fields :(
@Berrysoft
Copy link
Copy Markdown
Member

Interestingly I'm getting one test failure on my machine...

Oh, it's a logical bug of this test. I'll fix it later.

@Berrysoft Berrysoft self-requested a review March 30, 2024 06:44
@Berrysoft Berrysoft added bug Something isn't working driver: io-uring About the io-uring driver labels Mar 30, 2024
Copy link
Copy Markdown
Member

@Berrysoft Berrysoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 6e8bcdf into compio-rs:master Mar 30, 2024
@valpackett valpackett deleted the musl branch March 30, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working driver: io-uring About the io-uring driver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants