Skip to content

PSCE-239: feat: adds validation for YAML trestle rules#52

Merged
afflom merged 3 commits intocomplytime:mainfrom
jpower432:PSCE-239-v2
Oct 12, 2023
Merged

PSCE-239: feat: adds validation for YAML trestle rules#52
afflom merged 3 commits intocomplytime:mainfrom
jpower432:PSCE-239-v2

Conversation

@jpower432
Copy link
Copy Markdown
Member

@jpower432 jpower432 commented Oct 4, 2023 •
edited
Loading

Description

Adds basic validation implementation which allows for additional validation on top of pydantic.

  • The added validation currently checks that the parameter and alternatives values are structured correctly

Some Ideas for future validation

  • Check that the profiles referenced are accessible.

Blocked #50

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Unit tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 changed the title feat: adds validation for YAML trestle rules PSCE-239: feat: adds validation for YAML trestle rules Oct 4, 2023
@jpower432 jpower432 requested a review from afflom October 10, 2023 17:27
@jpower432 jpower432 marked this pull request as draft October 11, 2023 16:38
@jpower432
feat(transformers): initial validation handler from pre-validation be…
8d28bb7 
…fore pydantic

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: fixes spelling error on csv_transformer.py comment
d9ed863 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
feat(task): adds collection of validation errors in rules task
480e523 
Updates the rules transform task to make sure all errors for a
component defintion are collection during transformation and presented
back to the user to make errors easier to address at one time.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 marked this pull request as ready for review October 11, 2023 17:32
@afflom afflom merged commit 11a1a7c into complytime:main Oct 12, 2023
@marcusburghardt marcusburghardt mentioned this pull request Apr 21, 2026
Merged
marcusburghardt added a commit to marcusburghardt/complyscribe that referenced this pull request Apr 21, 2026
@marcusburghardt
fix: update nltk to 3.9.4 to resolve security vulnerabilities
47ac214 
Updates nltk to 3.9.4 for Python >= 3.10 environments. This resolves
multiple security advisories affecting nltk <= 3.9.2/3.9.3.

Note: nltk 3.9.4 requires Python >= 3.10. For Python 3.9 environments,
nltk remains at 3.9.2 due to upstream compatibility constraints.

Resolves Dependabot alerts: complytime#52, complytime#71, complytime#63, complytime#62, complytime#61, complytime#60
See: GHSA-7p94-766c-hgjp
See: GHSA-h8wq-7xc4-p3qx
See: GHSA-469j-vmhf-r6v7
See: GHSA-jm6w-m3j8-898g
See: GHSA-p423-j2cm-9vmq
See: GHSA-gfwx-w7gr-fvh7
See: GHSA-rf74-v2fm-23pw

Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt added a commit to marcusburghardt/complyscribe that referenced this pull request Apr 22, 2026
@marcusburghardt
fix: update nltk to 3.9.4 to resolve security vulnerabilities
d41b845 
Updates nltk to 3.9.4 for Python >= 3.10 environments. This resolves
multiple security advisories affecting nltk <= 3.9.2/3.9.3.

Note: nltk 3.9.4 requires Python >= 3.10. For Python 3.9 environments,
nltk remains at 3.9.2 due to upstream compatibility constraints.

Resolves Dependabot alerts: complytime#52, complytime#71, complytime#63, complytime#62, complytime#61, complytime#60
See: GHSA-7p94-766c-hgjp
See: GHSA-h8wq-7xc4-p3qx
See: GHSA-469j-vmhf-r6v7
See: GHSA-jm6w-m3j8-898g
See: GHSA-p423-j2cm-9vmq
See: GHSA-gfwx-w7gr-fvh7
See: GHSA-rf74-v2fm-23pw

Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt added a commit to marcusburghardt/complyscribe that referenced this pull request Apr 22, 2026
@marcusburghardt
fix: update nltk to 3.9.4 to resolve security vulnerabilities
5e50b65 
Updates nltk to 3.9.4 for Python >= 3.10 environments. This resolves
multiple security advisories affecting nltk <= 3.9.2/3.9.3.

Note: nltk 3.9.4 requires Python >= 3.10. For Python 3.9 environments,
nltk remains at 3.9.2 due to upstream compatibility constraints.

Resolves Dependabot alerts: complytime#52, complytime#71, complytime#63, complytime#62, complytime#61, complytime#60
See: GHSA-7p94-766c-hgjp
See: GHSA-h8wq-7xc4-p3qx
See: GHSA-469j-vmhf-r6v7
See: GHSA-jm6w-m3j8-898g
See: GHSA-p423-j2cm-9vmq
See: GHSA-gfwx-w7gr-fvh7
See: GHSA-rf74-v2fm-23pw

Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@afflom afflom afflom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpower432 @afflom