Skip to content

test: add e2e scenarios for create-cd#69

Merged
afflom merged 2 commits intocomplytime:mainfrom
jpower432:test/create-cd-e2e
Oct 30, 2023
Merged

test: add e2e scenarios for create-cd#69
afflom merged 2 commits intocomplytime:mainfrom
jpower432:test/create-cd-e2e

Conversation

@jpower432
Copy link
Copy Markdown
Member

@jpower432 jpower432 commented Oct 24, 2023 •
edited
Loading

Description

Add e2e scenario for testing create-cd in a containerized environment.

  • Adds the new command test with multiple scenarios
  • Adds additional validations to both E2E tests
  • Add the ability to skip image building if the image is available.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Run make test-e2e

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 force-pushed the test/create-cd-e2e branch 2 times, most recently from af28f88 to b1ff676 Compare October 26, 2023 21:29
@jpower432
test: add e2e scenarios for create-cd
719b5cc 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
test: updates test_e2e.py with additional assertions
6188344 
Adds assertions to check the command outcome
Adds a function to check if the image exists
Updates e2e README.md

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 marked this pull request as ready for review October 27, 2023 13:03
@jpower432
Copy link
Copy Markdown
Member Author

jpower432 commented Oct 30, 2023 •
edited
Loading

@afflom A follow on PR could look into podman python library - https://github.com/containers/podman-py instead of running these in sub-processes.

@jpower432 jpower432 marked this pull request as draft October 30, 2023 20:33
@jpower432 jpower432 marked this pull request as ready for review October 30, 2023 20:37
@afflom afflom merged commit 12af59f into complytime:main Oct 30, 2023
@jpower432 jpower432 deleted the test/create-cd-e2e branch March 26, 2024 13:51
@marcusburghardt marcusburghardt mentioned this pull request Apr 21, 2026
Merged
marcusburghardt added a commit to marcusburghardt/complyscribe that referenced this pull request Apr 21, 2026
@marcusburghardt
fix: update pytest to 9.0.3 to resolve security vulnerability
e6a8585 
Updates pytest from 8.4.2 to 9.0.3 to address a vulnerable tmpdir
handling issue.

Note: pytest 9.0.3 requires Python >= 3.10. The dependency constraint
is now restricted to Python >= 3.10 environments accordingly. For
Python 3.9, pytest remains at 8.4.2.

Resolves Dependabot alert: complytime#69
See: GHSA-6w46-j5rx-g56g

Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt added a commit to marcusburghardt/complyscribe that referenced this pull request Apr 22, 2026
@marcusburghardt
fix: update pytest to 9.0.3 to resolve security vulnerability
cb11322 
Updates pytest from 8.4.2 to 9.0.3 to address a vulnerable tmpdir
handling issue.

Note: pytest 9.0.3 requires Python >= 3.10. The dependency constraint
is now restricted to Python >= 3.10 environments accordingly. For
Python 3.9, pytest remains at 8.4.2.

Resolves Dependabot alert: complytime#69
See: GHSA-6w46-j5rx-g56g

Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt added a commit to marcusburghardt/complyscribe that referenced this pull request Apr 22, 2026
@marcusburghardt
fix: update pytest to 9.0.3 to resolve security vulnerability
29add94 
Updates pytest from 8.4.2 to 9.0.3 to address a vulnerable tmpdir
handling issue.

Note: pytest 9.0.3 requires Python >= 3.10. The dependency constraint
is now restricted to Python >= 3.10 environments accordingly. For
Python 3.9, pytest remains at 8.4.2.

Resolves Dependabot alert: complytime#69
See: GHSA-6w46-j5rx-g56g

Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt added a commit to marcusburghardt/complyscribe that referenced this pull request Apr 22, 2026
@marcusburghardt
fix: update pytest to 9.0.3 to resolve security vulnerability
067699d 
Updates pytest from 8.4.2 to 9.0.3 to address a vulnerable tmpdir
handling issue.

Note: pytest 9.0.3 requires Python >= 3.10. The dependency constraint
is now restricted to Python >= 3.10 environments accordingly. For
Python 3.9, pytest remains at 8.4.2.

Resolves Dependabot alert: complytime#69
See: GHSA-6w46-j5rx-g56g

Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beatrizmcouto beatrizmcouto Awaiting requested review from beatrizmcouto

1 more reviewer

@afflom afflom afflom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpower432 @afflom